Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material-experimental/mdc-radio): add functionality and styling #18272

Merged
merged 5 commits into from
Feb 7, 2020

Conversation

andrewseguin
Copy link
Contributor

Demo and tests copied from existing radio

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 23, 2020
@andrewseguin andrewseguin added pr: merge safe target: minor This PR is targeted for the next minor release labels Jan 23, 2020
@andrewseguin
Copy link
Contributor Author

Tests pass for me locally, not sure what's causing the issues on CI - seems the MatRadioModule isn't getting loaded into the unit tests

@devversion
Copy link
Member

@andrewseguin I pulled your branch and tested locally. You were not seeing these test failures locally because the tests actually pass with Ivy. They just fail with View Engine. This is because inputs declared in the component metadata are not inherited in View Engine. You need to add the inputs from the mixins:

  inputs: ['disableRipple', 'tabIndex'],

Hope that helps 😄

@andrewseguin
Copy link
Contributor Author

Thanks for the tip Paul, that did the trick!

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 4, 2020
@mmalerba mmalerba merged commit 59fce28 into angular:master Feb 7, 2020
@mmalerba mmalerba added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Feb 7, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants