Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: event emitter type #18664

Merged
merged 2 commits into from
Mar 4, 2020
Merged

fix: event emitter type #18664

merged 2 commits into from
Mar 4, 2020

Conversation

hmil
Copy link

@hmil hmil commented Feb 29, 2020

This incorrect type was revealed by (and is blocking) angular/angular#35300

@hmil hmil requested a review from andrewseguin as a code owner February 29, 2020 22:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 29, 2020
crisbeto
crisbeto approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Mar 1, 2020
@mmalerba mmalerba merged commit 400901b into angular:master Mar 4, 2020
mmalerba added a commit that referenced this pull request Mar 6, 2020
@mmalerba
fix: event emitter type (#18664)
b486891 
* fix: event emitter type

* regenerate golden api
This was referenced Mar 13, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 2, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hmil @crisbeto @googlebot @mmalerba