fix(radio): Move .mat-radio-input above .mat-focus-indicator. #18709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can apply styles to .mat-focus-indicator with CSS based upon whether or not .mat-radio-input is focused.
googlebot
added
the
cla: yes
mmalerba
added
lgtm
action: merge
|
Marking as merge safe since Zack already ran a TGP for this PR |
jelbourn
reviewed
Mar 5, 2020
mmalerba
added a commit
that referenced
this pull request
Mar 6, 2020
* fix(radio): Move .mat-radio-input above .mat-focus-indicator so that we can apply styles to .mat-focus-indicator with CSS based upon whether or not .mat-radio-input is focused. * Explicitly add comment explaining why ripple must come after input.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why we want to do this is so that we can apply styles to
.mat-focus-indicatorbased upon whether or not.mat-radio-inputis focused. We can't do this right now, because we there is no way to "look backwards" with CSS selectors. After this change, we will be able to write:This change also aligns the DOM structure of radio button with checkbox and slide toggle (the two latter components already have their inputs before the focus indicator element in the DOM).
Ran TGP, no failures.