Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): remove potentially leaky observable #19146

Merged
merged 1 commit into from
May 8, 2020
Merged

fix(overlay): remove potentially leaky observable #19146

merged 1 commit into from
May 8, 2020

Conversation

crisbeto
Copy link
Member

Removes an unnecessary observable that has the potential for memory leaks.

Fixes #10573.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 22, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner April 22, 2020 21:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 22, 2020
jelbourn
jelbourn approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - looks like there's a lint error though

@jelbourn jelbourn added the lgtm label Apr 22, 2020
@crisbeto
fix(overlay): remove potentially leaky observable
2a02099 
Removes an unnecessary observable that has the potential for memory leaks.

Fixes angular#10573.
@crisbeto crisbeto force-pushed the 10573/leaky-observable branch from 0750d93 to 2a02099 Compare April 23, 2020 05:34
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 23, 2020
@jelbourn jelbourn merged commit 27a812b into angular:master May 8, 2020
jelbourn pushed a commit that referenced this pull request May 8, 2020
@crisbeto @jelbourn
fix(overlay): remove potentially leaky observable (#19146)
6f79527 
Removes an unnecessary observable that has the potential for memory leaks.

Fixes #10573.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

100% reproducible memory leak
4 participants
@crisbeto @jelbourn @devversion @googlebot