fix(autocomplete): incorrectly detecting shadow DOM when inserted through an embedded view #19332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
19330/autocomplete-shadow-dom-embedded-view
branch
from
1d4c28e to
2dcf795
Compare
…ough an embedded view When an autocomplete is inserted, we try to figure out whether it's in the shadow DOM so that we can handle outside clicks properly. It seems like our logic can run too early in some cases, causing it to be detected incorrectly. These changes move the logic later in the process, right before the overlay is attached to the DOM. Fixes angular#19330.
crisbeto
force-pushed
the
19330/autocomplete-shadow-dom-embedded-view
branch
from
2dcf795 to
d93406c
Compare
mmalerba
pushed a commit
that referenced
this pull request
May 15, 2020
…ough an embedded view (#19332)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an autocomplete is inserted, we try to figure out whether it's in the shadow DOM so that we can handle outside clicks properly. It seems like our logic can run too early in some cases, causing it to be detected incorrectly. These changes move the logic later in the process, right before the overlay is attached to the DOM.
Fixes #19330.
Note: In the first iteration I had a unit test for this, but I couldn't get it to pass on ViewEngine, because one of the APIs I used to query for an element in the shadow DOM wasn't working. Since we don't have a way of disabling tests for ViewEngine, I ended up reverting it.