Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/sidenav): mark sidenav content as scrollable #19848

Merged
merged 1 commit into from
Apr 6, 2021
Merged

fix(material/sidenav): mark sidenav content as scrollable #19848

merged 1 commit into from
Apr 6, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 3, 2020

Marks the sidenav's inner scrollable element as cdkScrollable so any overlays placed inside of it can update.

Fixes #19846.
Fixes #18453.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 3, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner July 3, 2020 06:29
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 3, 2020
@devversion devversion added the lgtm label Jul 3, 2020
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 3, 2020
mmalerba
mmalerba approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@mmalerba mmalerba mentioned this pull request Aug 14, 2020
Open
@crisbeto
fix(material/sidenav): mark sidenav content as scrollable
8733ff3 
Marks the sidenav's inner scrollable element as `cdkScrollable` so any overlays placed
inside of it can update.

Fixes angular#19846.
Fixes angular#18453.
@crisbeto crisbeto force-pushed the 19846/scrollable-sidenav branch from 806108d to 8733ff3 Compare December 27, 2020 13:05
@crisbeto crisbeto changed the title fix(sidenav): mark sidenav content as scrollable fix(material/sidenav): mark sidenav content as scrollable Dec 27, 2020
@annieyw annieyw merged commit 2fa78c6 into angular:master Apr 6, 2021
annieyw pushed a commit that referenced this pull request Apr 6, 2021
@crisbeto @annieyw
fix(material/sidenav): mark sidenav content as scrollable (#19848)
3ee9bcf 
Marks the sidenav's inner scrollable element as `cdkScrollable` so any overlays placed
inside of it can update.

Fixes #19846.
Fixes #18453.

(cherry picked from commit 2fa78c6)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
5 participants
@crisbeto @devversion @mmalerba @googlebot @annieyw