Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-list): add high contrast mode treatment #21376

Merged
merged 1 commit into from
Apr 2, 2021
Merged

fix(material-experimental/mdc-list): add high contrast mode treatment #21376

merged 1 commit into from
Apr 2, 2021

Conversation

crisbeto
Copy link
Member

Adds similar high contrast mode treatment to the non-MDC list since the MDC implementation suffers from the same issues we had resolved before.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Dec 16, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 16, 2020
@crisbeto crisbeto force-pushed the mdc-list-high-contrast branch from 5e4ab87 to a194821 Compare December 18, 2020 12:29
@crisbeto crisbeto force-pushed the mdc-list-high-contrast branch from a194821 to ec44c90 Compare February 28, 2021 14:28
@crisbeto crisbeto force-pushed the mdc-list-high-contrast branch from ec44c90 to d66c577 Compare March 27, 2021 16:54
@crisbeto
fix(material-experimental/mdc-list): add high contrast mode treatment
a069555 
Adds similar high contrast mode treatment to the non-MDC list since the MDC
implementation suffers from the same issues we had resolved before.
@crisbeto crisbeto force-pushed the mdc-list-high-contrast branch from d66c577 to a069555 Compare March 27, 2021 16:57
mmalerba
mmalerba approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 29, 2021
devversion
devversion approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did we consider submitting an issue on the MDC repository?

@annieyw annieyw added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Apr 2, 2021
@annieyw annieyw merged commit 4f8e87e into angular:master Apr 2, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @mmalerba @annieyw