fix(material/dialog): focus restoration not working inside shadow dom #21811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to angular#21796. The dialog focus restoration works by grabbing `document.activeElement` before the dialog is opened and restoring focus to the element on destroy. This won't work if the element is inside the shadow DOM, because the browser will return the shadow root. These changes add a workaround.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
jelbourn
reviewed
Feb 5, 2021
| // If the `activeElement` is inside a shadow root, `document.activeElement` will | ||
| // point to the shadow root so we have to descend into it ourselves. | ||
| const activeElement = this._document.activeElement; | ||
| return activeElement?.shadowRoot?.activeElement as HTMLElement || activeElement; |
There was a problem hiding this comment.
Isn't it possible for the element to be within multiple layers of shadow dom?
There was a problem hiding this comment.
It is possible, but my assumption was activeElement would point to the closest shadow root. That being said, I haven't actually tried it. If that's the case, we might need some reusable utility under cdk/platform since we have a lot of places that look only at document.activeElement.
jelbourn
approved these changes
Feb 8, 2021
annieyw
pushed a commit
that referenced
this pull request
Mar 5, 2021
…#21811) Related to #21796. The dialog focus restoration works by grabbing `document.activeElement` before the dialog is opened and restoring focus to the element on destroy. This won't work if the element is inside the shadow DOM, because the browser will return the shadow root. These changes add a workaround. (cherry picked from commit be508da)
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21796. The dialog focus restoration works by grabbing
document.activeElementbefore the dialog is opened and restoring focus to the element on destroy. This won't work if the element is inside the shadow DOM, because the browser will return the shadow root. These changes add a workaround.