Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/progress-bar): Support ChromeVox #22166

Merged
merged 5 commits into from
Mar 19, 2021
Merged

fix(material/progress-bar): Support ChromeVox #22166

merged 5 commits into from
Mar 19, 2021

Conversation

jamOne-
Copy link
Contributor

@jamOne- jamOne- commented Mar 9, 2021

ChromeVox couldn't read a progress bar element without aria-hidden attributes set on child elements of mat-progress-bar.

Fixes #22165.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 9, 2021
jelbourn
jelbourn reviewed Mar 9, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamOne- thanks for the PR, I tested this locally and confirmed that this is an issue on ChromeVox and that this change fixes it.

Could you also make a similar update to the mdc-based progress-bar in the material-experimental directory?

@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround area: material/progress-bar target: patch This PR is targeted for the next patch release labels Mar 9, 2021
@jamOne- jamOne- requested a review from andrewseguin as a code owner March 10, 2021 07:03
@jamOne- jamOne- force-pushed the progress-bar-chromevox-fix branch from ae8e5b3 to 0844d64 Compare March 10, 2021 07:14
@jamOne-
Copy link
Contributor Author

jamOne- commented Mar 10, 2021

Applied the fix to mdc-progress-bar too

crisbeto
crisbeto reviewed Mar 10, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a unit test for this or at least a comment with some context?

@jamOne-
Copy link
Contributor Author

jamOne- commented Mar 10, 2021

Fair point, I'll add comments.
Regarding the tests, I'm not sure how to test this, do you have something in mind?

@crisbeto
Copy link
Member

It would basically be expect(div.getAttribute('aria-hidden')).toBe('true'). The main purpose is that something fails if somebody were to remove it in the future.

@jamOne-
Copy link
Contributor Author

jamOne- commented Mar 11, 2021

Added the tests, LMK if I could write them better

@jamOne- jamOne- requested a review from crisbeto March 11, 2021 06:34
crisbeto
crisbeto approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 11, 2021
jelbourn
jelbourn approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 13, 2021
@crisbeto
fix(material/progress-spinner): resolve accessibility issue in ChromeVox
32779d2 
Along the same lines as angular#22166. Marks all the root nodes in the progress spinner as
`aria-hidden` in order to work around an issue in ChromeVox.
@crisbeto crisbeto mentioned this pull request Mar 13, 2021
Merged
@andrewseguin andrewseguin merged commit 5b7b03e into angular:master Mar 19, 2021
andrewseguin pushed a commit that referenced this pull request Mar 19, 2021
@jamOne- @andrewseguin
fix(material/progress-bar): Support ChromeVox (#22166)
f950c03 
* fix(material/progress-bar): Support ChromeVox

* refactor(material/progress-bar): wrap elements with aria-hidden div

* fix(material-experimental/mdc-progress-bar): Support ChromeVox #22165

* test(material/progress-bar): add ChromeVox support tests

* test(material-experimental/mdc-progress-bar): add ChromeVox support test

(cherry picked from commit 5b7b03e)
andrewseguin pushed a commit that referenced this pull request Mar 19, 2021
@crisbeto
fix(material/progress-spinner): resolve accessibility issue in Chrome…
2da7135 
…Vox (#22219)

Along the same lines as #22166. Marks all the root nodes in the progress spinner as
`aria-hidden` in order to work around an issue in ChromeVox.
andrewseguin pushed a commit that referenced this pull request Mar 19, 2021
@crisbeto @andrewseguin
fix(material/progress-spinner): resolve accessibility issue in Chrome…
0e0b84a 
…Vox (#22219)

Along the same lines as #22166. Marks all the root nodes in the progress spinner as
`aria-hidden` in order to work around an issue in ChromeVox.

(cherry picked from commit 2da7135)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/progress-bar cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-progress-bar): ChromeVox can't read a progress bar
4 participants
@jamOne- @crisbeto @jelbourn @andrewseguin