Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/autocomplete): avoid assigning invalid aria-labelledby values #22261

Merged
merged 1 commit into from
Mar 19, 2021
Merged

fix(material/autocomplete): avoid assigning invalid aria-labelledby values #22261

merged 1 commit into from
Mar 19, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 17, 2021 •
edited
Loading

  • Fixes that we assign aria-labelledby even if there is no label.
  • Fixes that we don't trim the value of aria-labelledby when there is no label, but there is a custom aria-labelledby.

Fixes #22256.

@crisbeto
fix(material/autocomplete): avoid assigning invalid aria-labelledby v…
4f539b5 
…alues

* Fixes that we assign `aria-labelledby` even if there is no label.
* Fixes that we don't trim the value of `aria-labelledby` when there is no label, but
there is a custom `aria-labelledby`.

Fixes angular#22256.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Mar 17, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 17, 2021
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Mar 17, 2021
@andrewseguin andrewseguin merged commit ee49922 into angular:master Mar 19, 2021
andrewseguin pushed a commit that referenced this pull request Mar 19, 2021
@crisbeto @andrewseguin
fix(material/autocomplete): avoid assigning invalid aria-labelledby v…
19ca1b2 
…alues (#22261)

* Fixes that we assign `aria-labelledby` even if there is no label.
* Fixes that we don't trim the value of `aria-labelledby` when there is no label, but
there is a custom `aria-labelledby`.

Fixes #22256.

(cherry picked from commit ee49922)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@annieyw annieyw annieyw approved these changes

Assignees

@annieyw annieyw

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-autocomplete): panel listbox generates invalid aria-labeledby when a mat-label isn't present
3 participants
@crisbeto @annieyw @andrewseguin