Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): toggle icon not visible in high contrast mode on Chromium browsers #22352

Merged
merged 1 commit into from
Apr 2, 2021
Merged

fix(material/datepicker): toggle icon not visible in high contrast mode on Chromium browsers #22352

merged 1 commit into from
Apr 2, 2021

Conversation

crisbeto
Copy link
Member

Fixes an issue where the datepicker toggle icon blends in with the background in high contrast mode on Chromium-based browsers (Edge and Chrome).

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Mar 26, 2021
@crisbeto crisbeto requested a review from mmalerba as a code owner March 26, 2021 19:54
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 26, 2021
@crisbeto
fix(material/datepicker): toggle icon not visible in high contrast mo…
9de884a 
…de on Chromium browsers

Fixes an issue where the datepicker toggle icon blends in with the background in high contrast mode on Chromium-based browsers (Edge and Chrome).
@crisbeto crisbeto force-pushed the datepicker-toggle-high-contrast branch from 5026481 to 9de884a Compare March 26, 2021 20:02
mmalerba
mmalerba approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 29, 2021
@annieyw annieyw merged commit ea5e5e0 into angular:master Apr 2, 2021
annieyw pushed a commit that referenced this pull request Apr 2, 2021
@crisbeto @annieyw
fix(material/datepicker): toggle icon not visible in high contrast mo…
56840c3 
…de on Chromium browsers (#22352)

Fixes an issue where the datepicker toggle icon blends in with the background in high contrast mode on Chromium-based browsers (Edge and Chrome).

(cherry picked from commit ea5e5e0)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @annieyw