Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google-maps): add icon input to marker #22357

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

crisbeto
Copy link
Member

Currently the only way to control the icon of a marker is through the options object which can be cumbersome. These changes add a dedicated icon input which can be used to only change the icon.

Fixes #22097.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release labels Mar 27, 2021
@crisbeto crisbeto requested a review from a team as a code owner March 27, 2021 16:45
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 27, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 29, 2021
@wagnermaciel
Copy link
Contributor

@crisbeto Could you push to this again? CircleCI didn't run for some reason

Currently the only way to control the icon of a marker is through the `options` object which can be cumbersome. These changes add a dedicated `icon` input which can be used to only change the icon.

Fixes angular#22097.
@crisbeto crisbeto force-pushed the 22097/marker-icon branch from 5cba7e1 to 85319bc Compare March 30, 2021 19:21
@crisbeto
Copy link
Member Author

Done.

@annieyw annieyw merged commit 10ecfa0 into angular:master Apr 2, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add input to control map marker icon
4 participants