Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): Only update selection when value changed (#21847) #22369

Merged
merged 1 commit into from
May 3, 2021
Merged

fix(material/datepicker): Only update selection when value changed (#21847) #22369

merged 1 commit into from
May 3, 2021

Conversation

mcalmus
Copy link
Contributor

@mcalmus mcalmus commented Mar 30, 2021

Changes date selection to only update controls when value has changed. This is a fix for part of #21847

@mcalmus mcalmus requested a review from mmalerba as a code owner March 30, 2021 12:30
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 30, 2021
crisbeto
crisbeto reviewed Apr 4, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will also need a unit test.

Also you'll have to run yarn approve-api datepicker to fix the API golden CI check.

@mcalmus mcalmus force-pushed the fix-21847 branch 4 times, most recently from 1e550b8 to e1f1585 Compare April 10, 2021 14:56
@mcalmus
Copy link
Contributor Author

mcalmus commented Apr 25, 2021

The unit test is now there which made me realize the comparison logic was wrong. It should now all be in place and working as intended.

@mcalmus mcalmus force-pushed the fix-21847 branch 2 times, most recently from 67a3e81 to c7d5b27 Compare April 25, 2021 13:38
@mcalmus mcalmus force-pushed the fix-21847 branch 3 times, most recently from e4faf43 to df28ffc Compare April 27, 2021 19:14
mmalerba
mmalerba approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 27, 2021
@annieyw annieyw merged commit 979a4fa into angular:master May 3, 2021
annieyw pushed a commit that referenced this pull request May 3, 2021
@mcalmus @annieyw
fix(material/datepicker): Only update selection when value changed (#…
6fe273c 
…21846) (#22369)

(cherry picked from commit 979a4fa)
annieyw pushed a commit that referenced this pull request May 3, 2021
@mcalmus @annieyw
fix(material/datepicker): Only update selection when value changed (#…
35c0483 
…21846) (#22369)

(cherry picked from commit 979a4fa)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcalmus @crisbeto @mmalerba @annieyw