Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-list): align ripple timings with MDC #22396

Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix(material-experimental/mdc-list): align ripple timings with MDC #22396

merged 1 commit into from
Apr 7, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 4, 2021

Uses the ripple timing values from MDC for our implementation so that it's consistent with the spec.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 4, 2021
@crisbeto crisbeto requested a review from devversion April 4, 2021 09:54
@crisbeto crisbeto requested a review from mmalerba as a code owner April 4, 2021 09:54
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 4, 2021
@crisbeto crisbeto force-pushed the mdc-list-ripple-timing branch 2 times, most recently from 1c671dc to e049f4b Compare April 4, 2021 12:58
devversion
devversion approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
fix(material-experimental/mdc-list): align ripple timings with MDC
1087828 
Uses the ripple timing values from MDC for our implementation so that it's consistent with the spec.
@crisbeto crisbeto force-pushed the mdc-list-ripple-timing branch from e049f4b to 1087828 Compare April 5, 2021 17:53
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 5, 2021
@annieyw annieyw merged commit 4ad2d96 into angular:master Apr 7, 2021
annieyw pushed a commit that referenced this pull request Apr 7, 2021
@crisbeto @annieyw
fix(material-experimental/mdc-list): align ripple timings with MDC (#…
1e8de9c 
…22396)

Uses the ripple timing values from MDC for our implementation so that it's consistent with the spec.

(cherry picked from commit 4ad2d96)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @annieyw