Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/tabs): coloring issues when a backgroundColor is set #22612

Merged
merged 1 commit into from
May 7, 2021
Merged

fix(material/tabs): coloring issues when a backgroundColor is set #22612

merged 1 commit into from
May 7, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 2, 2021

Resolves several issues related to the color of icons and ripples in the tab header, when it has a non-default backgroundColor.

Fixes #22587.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 2, 2021
@crisbeto crisbeto requested a review from andrewseguin May 2, 2021 08:23
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 2, 2021
@crisbeto
fix(material/tabs): coloring issues when a backgroundColor is set
c6015b0 
Resolves several issues related to the color of icons and ripples in the tab header, when it has a non-default `backgroundColor`.

Fixes angular#22587.
@crisbeto crisbeto force-pushed the 22587/tabs-background-chevrons branch from d7040c2 to c6015b0 Compare May 2, 2021 11:25
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label May 4, 2021
@mmalerba mmalerba added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 7, 2021
@mmalerba mmalerba merged commit 49e60ac into angular:master May 7, 2021
mmalerba pushed a commit that referenced this pull request May 7, 2021
@crisbeto @mmalerba
fix(material/tabs): coloring issues when a backgroundColor is set (#2…
cc95e86 
…2612)

Resolves several issues related to the color of icons and ripples in the tab header, when it has a non-default `backgroundColor`.

Fixes #22587.

(cherry picked from commit 49e60ac)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatTabGroup pagination chevron incorrect color when using backgroundColor property
3 participants
@crisbeto @andrewseguin @mmalerba