Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @angular2-material/all #236

Closed
PatrickJS opened this issue Mar 28, 2016 · 7 comments
Closed

feat: @angular2-material/all #236

PatrickJS opened this issue Mar 28, 2016 · 7 comments
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone

Comments

@PatrickJS
Copy link
Member

it would be great if we had @angular2-material/all that also exported MATERIAL_DIRECTIVES and MATERIAL_PROVIDERS. At the moment, you need to require everything manually

import {MD_SIDENAV_DIRECTIVES} from '@angular2-material/sidenav';
import {MdToolbar} from '@angular2-material/toolbar';
import {MdButton} from '@angular2-material/button';
import {MdCheckbox} from '@angular2-material/checkbox';
import {MdRadioButton} from '@angular2-material/radio';
import {MdSpinner} from '@angular2-material/progress-circle';
import {MD_CARD_DIRECTIVES} from '@angular2-material/card';
const MATERIAL_DIRECTIVES = [
  ...MD_SIDENAV_DIRECTIVES,
  ...[ MdToolbar, MdButton, MdCheckbox, MdRadioButton, MdSpinner ],
  ...MD_CARD_DIRECTIVES
];
  "dependencies": {
    "@angular2-material/button": "^2.0.0-alpha.1",
    "@angular2-material/card": "^2.0.0-alpha.1",
    "@angular2-material/checkbox": "^2.0.0-alpha.1",
    "@angular2-material/core": "^2.0.0-alpha.1",
    "@angular2-material/progress-circle": "^2.0.0-alpha.1",
    "@angular2-material/radio": "^2.0.0-alpha.1",
    "@angular2-material/sidenav": "^2.0.0-alpha.1",
    "@angular2-material/toolbar": "^2.0.0-alpha.1",
    "angular2": "2.0.0-beta.12",
    "core-js": "^2.1.5",
    "rxjs": "5.0.0-beta.2",
    "zone.js": "0.6.6"
  },
@jelbourn jelbourn added this to the alpha.3 milestone Mar 28, 2016
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Mar 28, 2016
@jelbourn jelbourn self-assigned this Mar 28, 2016
@jelbourn jelbourn modified the milestones: before beta, alpha.3 Apr 21, 2016
@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label May 18, 2016
@naveedahmed1
Copy link

naveedahmed1 commented May 30, 2016

I believe both options should be supported, i.e

import all MATERIAL_DIRECTIVES and MATERIAL_PROVIDER
Good for the projects utilizing all/most of the directive/providers

import specific MATERIAL_DIRECTIVES and MATERIAL_PROVIDER
Good for projects utilizing only specific directives

May be more options could be given by grouping related directives:

@angular2-material/all
import all directives

@angular2-material/form-directives
import form related directives such as input, checkboxes, radio, slide toggle, select etc.

@angular2-material/ui
import ui related directives related directives such as side nav, menu, list, dialog, tabs etc.

@m0t0r
Copy link

m0t0r commented Aug 15, 2016

@jelbourn this issue seems ready to be closed as #950 exports all module.

@itrethan
Copy link

Can you please release the @angular2-material/all to npm repo? The code is there but it's not available in npm.

@elvirdolic
Copy link

@itrethan you can copy this code and adapt it to your needs. This has the benefit that you can include in this file only modules which you use in your app instead of including all modules.

@devversion
Copy link
Member

@jelbourn I think this can be closed now?

@jelbourn
Copy link
Member

jelbourn commented Oct 4, 2016

Yep.

@jelbourn jelbourn closed this as completed Oct 4, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

7 participants