Clear duration timeout after dismiss

[sv2dev]

Fixes #4859

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[sv2dev]

I signed it!

[googlebot]

CLAs look good, thanks!

[sv2dev]

@jelbourn from my point of view this is ready to review.

[jelbourn]

This change needs a unit test that verifies the problem it aims to resolve no longer occurs.

[jelbourn]

I would call this durationTimeoutId with comment:

/**
 * Timeout ID for the duration setTimeout call. Used to clear the timeout if the snackbar is 
 * dismissed before the duration passes.
 */
private _durationTimeoutId: number;

[jelbourn]

This should be an private method. If it were a public API and someone called it in combination with setting a duration, the earlier timeout ID would be lost and the issue this PR aims to resolve would still occur.

[sv2dev]

Hi @jelbourn,

Thanks for reveiw.

I did the requested changes, but the tests seem to fail, since flush() (introduced in 4.2.0-rc.1) is missing in CI.
I'm not sure why this is the case.
I first thought, that the rc version of angular 4 in the yarn.lock might be the issue, but the travis job uses npm to install the dependencies.
When I run npm i, I get @angular/[email protected] installed and it has the flush() function.

Do you have any idea how to fix this or test the behavior differently?

[jelbourn]

@svi3c

  it('should clear the dismiss timeout when dismissed before timeout expiration', fakeAsync(() => {
    let config = new MdSnackBarConfig();
    config.duration = 1000;
    snackBar.open('content', 'test', config);

    setTimeout(() => snackBar.dismiss(), 500);

    tick(600);
    viewContainerFixture.detectChanges();
    flushMicrotasks();

    expect(viewContainerFixture.isStable()).toBe(true);
  }));

[sv2dev]

Hi @jelbourn,
the changes are applied.

[jelbourn]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}