-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e tests for icons #560
Comments
Hey @jelbourn, Do you mind if I take a shot? Or are you already working on this? |
Go ahead, not currently assigned |
How would you feel about leaving e2es out for icons since there is no real behavior to test, at least for the time being. It looks like all of the cases are covered via unit testing. Personally, I always try to limit e2es in favor of unit testing since they tend to be slow and flakey. Here is a good article on the subject if you are interested: http://googletesting.blogspot.com/2015/04/just-say-no-to-more-end-to-end-tests.html. If you feel differently I will go ahead and write tests if you would like. |
At the very least there should be some smoke-level e2e tests. |
Gotcha |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.
The text was updated successfully, but these errors were encountered: