Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for icons #560

Closed
jelbourn opened this issue May 27, 2016 · 6 comments · Fixed by #794
Closed

Add e2e tests for icons #560

jelbourn opened this issue May 27, 2016 · 6 comments · Fixed by #794
Milestone

Comments

@jelbourn
Copy link
Member

No description provided.

@jelbourn jelbourn added this to the alpha.6 milestone May 27, 2016
@jesselpalmer
Copy link
Member

Hey @jelbourn, Do you mind if I take a shot? Or are you already working on this?

@jelbourn
Copy link
Member Author

Go ahead, not currently assigned

@jesselpalmer
Copy link
Member

How would you feel about leaving e2es out for icons since there is no real behavior to test, at least for the time being. It looks like all of the cases are covered via unit testing. Personally, I always try to limit e2es in favor of unit testing since they tend to be slow and flakey. Here is a good article on the subject if you are interested: http://googletesting.blogspot.com/2015/04/just-say-no-to-more-end-to-end-tests.html. If you feel differently I will go ahead and write tests if you would like.

@jelbourn
Copy link
Member Author

jelbourn commented Jun 1, 2016

At the very least there should be some smoke-level e2e tests.

@jesselpalmer
Copy link
Member

Gotcha

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants