Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-button-toggle-group trigger change event when it should not #5880

Closed
MatthieuBarthel opened this issue Jul 19, 2017 · 1 comment · Fixed by #6034
Closed

md-button-toggle-group trigger change event when it should not #5880

MatthieuBarthel opened this issue Jul 19, 2017 · 1 comment · Fixed by #6034
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@MatthieuBarthel
Copy link

MatthieuBarthel commented Jul 19, 2017

Bug, feature request, or proposal:

Bug I think

What is the current behavior?

First of all, I am using a button-toggle-group as a form control, I am not sure that it is officially supported but I guess it is as the doc says it can behave as radio-buttons (and it works).

My issue is that this button-toggle-group triggers a change event when the formControl's value is updated with the setValue method. It is not the case with others material2 form controls (md-input, md-radio-group, md-select, etc.).

What is the expected behavior?

Not triggering the change event.

What are the steps to reproduce?

Here is a Plunker: http://plnkr.co/edit/N1HhjFtJiliGX0z9L2nT?p=preview
Simply click on the button on the top and you will see various material controls being updated, the latest (button-toggle-group) is the only one to trigger a change event.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material beta8 (+ latest snapshot), Angular 4.x, probably any browser.

Is there anything else we should know?

I love material2, thanks for the hard work !

@kara kara added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jul 20, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants