Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: rename placeholder to label #6240

Closed
mmalerba opened this issue Aug 2, 2017 · 5 comments
Closed

input: rename placeholder to label #6240

mmalerba opened this issue Aug 2, 2017 · 5 comments
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mmalerba
Copy link
Contributor

mmalerba commented Aug 2, 2017

These are now separate concepts in the newest version of the material spec. The thing we currently call "placeholder" is really the label. We need to rename it in order to free up the "placeholder" attribute to be used for its intended purpose. (Prerequisite to #6194)

@mmalerba mmalerba added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Aug 2, 2017
@mmalerba mmalerba self-assigned this Aug 2, 2017
@jwlundk
Copy link

jwlundk commented Oct 6, 2017

Hi,
I currently have a problem using placeholder with floatPlaceholder="always" and a readonly input. I tested with Chrome 61.
IE 11 and Edge seem to work.

Take a look at this plunkr: http://plnkr.co/edit/lAHxoFvEJXrJA9Em3Sqi?p=preview

When you doubleclick the text, the placeholder will be selected. I think this could be solved by separating placeholders and labels. Or should I create a new issue for this? Sorry, I am new to github, this is my first comment :)

@mmalerba
Copy link
Contributor Author

mmalerba commented Oct 6, 2017

@jwlundk yes this should be resolved when we separate them, in the mean time you can use the <mat-placeholder> element instead of the placeholder attribute to work around this: http://plnkr.co/edit/2O00ZmcRErxL9bHv1Xk4?p=preview

@jwlundk
Copy link

jwlundk commented Oct 9, 2017

@mmalerba your solution works great, thank you very much!

@mmalerba
Copy link
Contributor Author

closing as duplicate of #6194

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

2 participants