Map markers #16964
Map markers #16964
Conversation
googlebot
added
the
cla: yes
packages.bzl
Outdated
| @@ -82,6 +82,7 @@ MATERIAL_SCSS_LIBS = [ | |||
|
|
|||
| GOOGLE_MAPS_PACKAGES = [ | |||
| "google-map", | |||
| "google-map-marker", | |||
There was a problem hiding this comment.
I don't think this should be a separate sub-package; I would just make it a sub-directory of google-map that is in the same build unit (e.g. no new tsconfig, NgModule, SystemJS config BUILD file, etc.)
There was a problem hiding this comment.
I thought about this for awhile and I think you're right, that it should be in the same module. However, if that's the case, then we also shouldn't have a separate module for google-map. In other words, we should just have '@angular/google-maps' instead of '@angular/google-maps/google-map'. That's a pretty big refactor though, do you think it should be done in the same pull request?
There was a problem hiding this comment.
That will be fine in a follow-up. I never actually realized it wasn't one main module for the whole thing.
There was a problem hiding this comment.
Okay, that sounds good. For this one, I will connect google-map-marker to the google-map module, and in the subsequent cl, I will have both of them be in a google-maps module.
There was a problem hiding this comment.
I ran into some unexpected problems having google-map remain a separate subpackage but integrating map-marker. So, to avoid having to double my work, I decided to just combine everything into one package in this pr. It makes this already very large pr even bigger, but it should correct the build failures you saw.
mbehrlich
force-pushed
the
map-markers
branch
from
847c474 to
ee061b4
Compare
|
@mbehrlich looks like there's a build failure on CI |
Add a google-map-marker component that when used as a child to a google-map component, will display a marker on the map.
Add tests for the google-map-marker component.
Add tests to Google Map marker component.
Fix bug with demo bazel file and with fake data for marker test.
Make various fixes internal cleanup fixes. Change google-map-marker to map-marker. Use QueryList's changes property instead of a setter for ContentChildren.
Fix type bug with map marker tests.
Refactor google-maps module to have a single entry-point, @angular/google-maps, instead of a separate one for every component.
Fix formatting on google maps module.
mbehrlich
force-pushed
the
map-markers
branch
from
ee061b4 to
c574a10
Compare
|
CI failure looks like you're just missing a |
jelbourn
added
pr: lgtm
target: minor
Add GoogleMap and MapMarker components to index for the google maps module.
jelbourn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds google-map-marker component.