Skip to content

Commit

Permalink
fix(table): move padding from rows to cells (#10499)
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewseguin authored Mar 20, 2018
1 parent 1dd8a27 commit e0321db
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion src/lib/table/table.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ $mat-row-horizontal-padding: 24px;
border-bottom-width: 1px;
border-bottom-style: solid;
align-items: center;
padding: 0 $mat-row-horizontal-padding;
box-sizing: border-box;

// Workaround for https://goo.gl/pFmjJD in IE 11. Adds a pseudo
Expand All @@ -32,8 +31,19 @@ $mat-row-horizontal-padding: 24px;
}
}

.mat-cell:first-child, .mat-header-cell:first-child {
padding-left: $mat-row-horizontal-padding;
}

.mat-cell:last-child, .mat-header-cell:last-child {
padding-right: $mat-row-horizontal-padding;
}

.mat-cell, .mat-header-cell {
flex: 1;
display: flex;

This comment has been minimized.

Copy link
@kvetis

kvetis Jun 1, 2018

This is a breaking change (at least for us) if you use multiple vertical elements in a cell. Should it be mentioned in changelog?

This comment has been minimized.

Copy link
@andrewseguin

andrewseguin Jun 8, 2018

Author Contributor

Yes, this should have been mentioned in the CHANGELOG during our 6.0.0 beta. It's not clear why the log did not pick up this pull request's BREAKING CHANGES

https://github.com/angular/material2/blob/master/CHANGELOG.md#600-beta5-2018-03-23

This comment has been minimized.

Copy link
@vesrah

vesrah Aug 10, 2018

I also got bitten by this.

align-items: center;
overflow: hidden;
word-wrap: break-word;
min-height: inherit;
}

0 comments on commit e0321db

Please sign in to comment.