fix(menu): detach lazily-rendered content when the menu is closed #10005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
9915/menu-detach-lazy-content
branch
from
06d03ed to
b3f9677
Compare
|
@crisbeto We need to fix the test |
Currently the lazily-rendered content is maintained in the background while a menu is open. These changes switch to detaching it once the user closes the menu. Fixes angular#9915.
crisbeto
force-pushed
the
9915/menu-detach-lazy-content
branch
from
b3f9677 to
13255d7
Compare
|
Fixed @tinayuangao. Looks like I had messed up a rebase. |
tinayuangao
added a commit
to tinayuangao/material2
that referenced
this pull request
Mar 5, 2018
tinayuangao
added a commit
that referenced
this pull request
Mar 6, 2018
This reverts commit c8ca770.
tinayuangao
added
target: minor
|
Changed the label to |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the lazily-rendered content is maintained in the background while a menu is open. These changes switch to detaching it once the user closes the menu.
Fixes #9915.