Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are not mirrored on RTL #10045

Closed
philip-firstorder opened this issue Feb 20, 2018 · 1 comment · Fixed by #10327
Closed

Icons are not mirrored on RTL #10045

philip-firstorder opened this issue Feb 20, 2018 · 1 comment · Fixed by #10327
Assignees
Labels
help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions

Comments

@philip-firstorder
Copy link

philip-firstorder commented Feb 20, 2018

Bug, feature request, or proposal:

Icons are not mirrored on RTL like in the guidelines.

What is the expected behavior?

To mirror all the icons on RTL except the ones described in chapter "When not to mirror" (refresh, history, keyboard, headset, search, local_cafe, slashed icons, media playback icons, ...)

I think applying a transform: scale(-1, 1); will do the job, making sure to skip the excluded icons.

What is the current behavior?

Icons are not mirrored at all.

What are the steps to reproduce?

Press RTL
https://tina-material-tree.firebaseapp.com/button

What is the use-case or motivation for changing an existing behavior?

To follow the guidelines on mirroring the icons on RTL.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

"@angular/material": "^5.2.1",

Is there anything else we should know?

I found a list of icons that can be mirrored here: http://google.github.io/material-design-icons/#icons-in-rtl

@josephperrott josephperrott added help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions labels Feb 20, 2018
@crisbeto crisbeto self-assigned this Mar 8, 2018
@crisbeto crisbeto added the has pr label Mar 8, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 8, 2018
Adds the `mat-icon-rtl-mirror` CSS class that can be used to mirror icons only in an RTL layout.

Fixes angular#10045.
jelbourn pushed a commit that referenced this issue Mar 9, 2018
Adds the `mat-icon-rtl-mirror` CSS class that can be used to mirror icons only in an RTL layout.

Fixes #10045.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants