fix(grid-list): default to LTR when Directionality value is empty #10111
+33
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
P1
googlebot
added
the
cla: yes
crisbeto
approved these changes
Feb 24, 2018
src/lib/grid-list/tile-styler.ts
Outdated
| @@ -106,7 +106,7 @@ export abstract class TileStyler { | |||
|
|
|||
| // The width and horizontal position of each tile is always calculated the same way, but the | |||
| // height and vertical position depends on the rowMode. | |||
| let side = this._direction === 'ltr' ? 'left' : 'right'; | |||
| let side = !this._direction || this._direction === 'ltr' ? 'left' : 'right'; | |||
There was a problem hiding this comment.
This one could be switched around to this._direction === 'rtl' ? 'right' : 'left'.
crisbeto
added
pr: lgtm
action: merge
jelbourn
force-pushed
the
grid-list-dir-fix
branch
from
8585075 to
557922f
Compare
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Feb 26, 2018
jelbourn
added a commit
to jelbourn/components
that referenced
this pull request
Feb 27, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7111 caused grid-lists inside of dialogs to get a
Directionalityvalue ofundefined, which made them default to RTL because of a overstrict check.