Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(portal): remove 6.0.0 deletion targets #10257

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 4, 2018

Removes the deletion targets for 6.0.0 in the cdk/portal entry point.

BREAKING CHANGES:

  • The portalHost and cdkPortalHost inputs which were deprecated in 5.0.0 have been removed. Use cdkPortalOutlet instead.

@crisbeto crisbeto requested a review from jelbourn as a code owner March 4, 2018 06:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 4, 2018
@crisbeto crisbeto force-pushed the portal-6.0.0-deletion-targets branch from 1d447e2 to 6fddcd9 Compare March 5, 2018 02:10
Removes the deletion targets for 6.0.0 in the `cdk/portal` entry point.

BREAKING CHANGES:
* The `portalHost` and `cdkPortalHost` inputs which were deprecated in 5.0.0 have been removed. Use `cdkPortalOutlet` instead.
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 5, 2018
@jelbourn
Copy link
Member

jelbourn commented Mar 5, 2018

Caretaker note: have to remove usages internally first

@mmalerba mmalerba merged commit 88abd9e into angular:master Mar 13, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants