Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chips): allow for separatorKeyCodes to be configured globally #10264

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 5, 2018

Adds the MAT_CHIPS_DEFAULT_OPTIONS injection token that allows consumers to override separatorKeyCodes, as well as any other options that we decide to add in the future, for the entire module.

Fixes #10256.

Adds the `MAT_CHIPS_DEFAULT_OPTIONS` injection token that allows consumers to override `separatorKeyCodes`, as well as any other options that we decide to add in the future, for the entire module.

Fixes angular#10256.
@crisbeto crisbeto requested a review from tinayuangao as a code owner March 5, 2018 02:16
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 5, 2018
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed pr: needs review labels Mar 9, 2018
@andrewseguin andrewseguin merged commit 3c8a498 into angular:master Mar 19, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matChipInput: Add global configuration option for separator key codes
4 participants