Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(badge): invalid style declaration and too broad transition #10433

Merged
merged 1 commit into from
Mar 19, 2018
Merged

fix(badge): invalid style declaration and too broad transition #10433

merged 1 commit into from
Mar 19, 2018

Conversation

crisbeto
Copy link
Member

  • Fixes the badge transition not working due to the transition declaration being invalid (no units on the duration).
  • Fixes the badge animating all properties rather than only the transform.
  • Avoids blurry text in IE.

@crisbeto
fix(badge): invalid style declaration and too broad transition
daf61da 
* Fixes the badge transition not working due to the `transition` declaration being invalid (no units on the duration).
* Fixes the badge animating all properties rather than only the `transform`.
* Avoids blurry text in IE.
@crisbeto crisbeto requested a review from amcdnl as a code owner March 15, 2018 10:34
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 15, 2018
josephperrott
josephperrott approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Mar 15, 2018
@jelbourn jelbourn added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Mar 15, 2018
@andrewseguin andrewseguin merged commit c14cf7c into angular:master Mar 19, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @josephperrott @jelbourn @googlebot @andrewseguin