feat(schematics): tree schematic #11739
Conversation
googlebot
added
the
cla: yes
| @@ -0,0 +1,22 @@ | |||
| <mat-tree [dataSource]="dataSource" [treeControl]="treeControl"> | |||
| <mat-tree-node *matTreeNodeDef="let node" matTreeNodeToggle matTreeNodePadding> | |||
| <button mat-icon-button disabled></button> | |||
There was a problem hiding this comment.
Could we omit this (empty/nonfunctional) button completely and just capture the spacing with a different element?
There was a problem hiding this comment.
I just copied what the docs examples did. Open to other ideas though. Just let me know.
There was a problem hiding this comment.
cc @tinayuangao there's no reason this needs to be a button, right? It's just to take up space?
There was a problem hiding this comment.
Yes, we should remove the button and use style to take up space.
| return node.level; | ||
| } | ||
|
|
||
| /** Return whether the node is expanded or not. */ |
There was a problem hiding this comment.
Return -> Get (for consistency with other methods)
src/lib/schematics/tree/index.ts
Outdated
| import {buildComponent} from '../utils/devkit-utils/component'; | ||
|
|
||
| /** | ||
| * Scaffolds a new navigation component. |
| <mat-tree-node *matTreeNodeDef="let node" matTreeNodeToggle matTreeNodePadding> | ||
| <button mat-icon-button disabled></button> | ||
| <mat-icon class="type-icon" [attr.aria-label]="node.type + 'icon'"> | ||
| {{ node.type ==='file' ? 'description' : 'folder' }} |
There was a problem hiding this comment.
I think you always omit braces here, no (here and elsewhere)? Also, there's a missing whitespace before 'file' (here and elsewhere).
| @@ -0,0 +1,113 @@ | |||
| import { Component<% if(!!viewEncapsulation) { %>, ViewEncapsulation<% }%><% if(changeDetection !== 'Default') { %>, ChangeDetectionStrategy<% }%> } from '@angular/core'; | |||
There was a problem hiding this comment.
Its used in every component schematic
There was a problem hiding this comment.
I commented on this in the other schematics too; I don't see a the need for it, and "because it was already like that" isn't a great reason for keeping it
| } | ||
|
|
||
| @Component({ | ||
| selector: '<%= selector %>',<% if(inlineTemplate) { %> |
There was a problem hiding this comment.
Missing whitespace before ( (here and elsewhere)?
|
Nudge @tinayuangao to take a look |
|
Hi @amcdnl! This PR has merge conflicts due to recent upstream merges. |
|
Nudge @tinayuangao |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR adds a new schematic for the Material Tree module.
See example here: https://material-tree.stackblitz.io