perf(tree): leaking reference through mostRecentTreeNode #12334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along the same lines as angular#12269. Clears out the `mostRecentTreeNode` once the last tree node is destroyed, in order to avoid a memory leak.
crisbeto
added
perf
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 23, 2018
|
|
||
| fixture.destroy(); | ||
|
|
||
| expect(!!CdkTreeNode.mostRecentTreeNode).toBe(false); |
There was a problem hiding this comment.
Just toBeFalsy or toBeNull here?
There was a problem hiding this comment.
I left a comment about it a few lines about. Using .toBeFalsy will cause Jasmine to go into an infinite loop, if this test ever starts failing, because it tries to stringify an object with circular references.
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Jul 30, 2018
Along the same lines as #12269. Clears out the `mostRecentTreeNode` once the last tree node is destroyed, in order to avoid a memory leak.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the same lines as #12269. Clears out the
mostRecentTreeNodeonce the last tree node is destroyed, in order to avoid a memory leak.