Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(progress-bar): query animation not working inside routes with named outlets #12350

Merged
merged 1 commit into from
Jul 26, 2018
Merged

fix(progress-bar): query animation not working inside routes with named outlets #12350

merged 1 commit into from
Jul 26, 2018

Conversation

crisbeto
Copy link
Member

This is something that was introduced by #12014. Because we didn't have quotes around the URL in the fill value, the reference could become invalid if the user is on a route with a named outlet, which contains parentheses in its URL.

Fixes #12338.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jul 24, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 24, 2018
@crisbeto
Copy link
Member Author

Marking as a P2 since this is a regression.

@crisbeto
fix(progress-bar): query animation not working inside routes with nam…
e21c70f 
…ed outlets

This is something that was introduced by angular#12014. Because we didn't have quotes around the URL in the `fill` value, the reference could become invalid if the user is on a route with a named outlet, which contains parentheses in its URL.

Fixes angular#12338.
@crisbeto crisbeto force-pushed the 12338/progress-bar-named-routes branch from cc62d92 to e21c70f Compare July 24, 2018 19:50
jelbourn
jelbourn approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 24, 2018
@mmalerba mmalerba merged commit b9c0d85 into angular:master Jul 26, 2018
mmalerba pushed a commit that referenced this pull request Jul 30, 2018
@crisbeto @mmalerba
fix(progress-bar): query animation not working inside routes with nam…
0c526d3 
…ed outlets (#12350)

This is something that was introduced by #12014. Because we didn't have quotes around the URL in the `fill` value, the reference could become invalid if the user is on a route with a named outlet, which contains parentheses in its URL.

Fixes #12338.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Animation does not work in versions 6.4.0 and 6.4.1 when MatProgressBar is set to buffer mode.
5 participants
@crisbeto @jelbourn @googlebot @josephperrott @mmalerba