perf(overlay): remove detached overlays from the DOM #12414
Conversation
crisbeto
added
perf
googlebot
added
the
cla: yes
|
Will this conflict with #11806? |
|
As far as I can tell no, because the overlay in #11806 never detaches, it just toggles |
src/cdk/overlay/overlay-ref.ts
Outdated
| @@ -31,6 +31,7 @@ export class OverlayRef implements PortalOutlet, OverlayReference { | |||
| private _backdropClick: Subject<MouseEvent> = new Subject(); | |||
| private _attachments = new Subject<void>(); | |||
| private _detachments = new Subject<void>(); | |||
| private _previousHostParent: HTMLElement; | |||
There was a problem hiding this comment.
Add a description for this that explains how its used?
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
Removes the detached overlays from the DOM, rather than keeping their host element. Previously we kept the elements in the DOM, because they don't interfere with user interactions and it made it easier to handle animations, however doing so can cause scroll jank, because the host still has dimensions and is being rendered by the browser. Fixes angular#12341.
crisbeto
force-pushed
the
12341/overlay-remove-bounding-box
branch
from
1319612 to
ed490c4
Compare
Removes the detached overlays from the DOM, rather than keeping their host element. Previously we kept the elements in the DOM, because they don't interfere with user interactions and it made it easier to handle animations, however doing so can cause scroll jank, because the host still has dimensions and is being rendered by the browser. Fixes #12341.
Removes the detached overlays from the DOM, rather than keeping their host element. Previously we kept the elements in the DOM, because they don't interfere with user interactions and it made it easier to handle animations, however doing so can cause scroll jank, because the host still has dimensions and is being rendered by the browser. Fixes #12341.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removes the detached overlays from the DOM, rather than keeping their host element. Previously we kept the elements in the DOM, because they don't interfere with user interactions and it made it easier to handle animations, however doing so can cause scroll jank, because the host still has dimensions and is being rendered by the browser.
Fixes #12341.