Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): dynamic chip input placeholder changes not being propagated to form field #12422

Merged
merged 1 commit into from
Aug 1, 2018
Merged

fix(chips): dynamic chip input placeholder changes not being propagated to form field #12422

merged 1 commit into from
Aug 1, 2018

Conversation

crisbeto
Copy link
Member

Fixes changes to the placeholder of a chip input not being propagated to its parent form field. Also un-deprecates the input for placeholder, because we need to know when it has changed.

Fixes #11861.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 28, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 28, 2018
jelbourn
jelbourn approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

Just needs rebase

@crisbeto
fix(chips): dynamic chip input placeholder changes not being propagat…
f24a2c5 
…ed to form field

Fixes changes to the placeholder of a chip input not being propagated to its parent form field. Also un-deprecates the input for `placeholder`, because we need to know when it has changed.

Fixes angular#11861.
@crisbeto crisbeto force-pushed the 11861/chips-dynamic-placeholder branch from 3920b6a to f24a2c5 Compare July 30, 2018 17:18
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jul 30, 2018
@jelbourn jelbourn merged commit e007c27 into angular:master Aug 1, 2018
jelbourn pushed a commit that referenced this pull request Aug 7, 2018
@crisbeto @jelbourn
fix(chips): dynamic chip input placeholder changes not being propagat…
5053532 
…ed to form field (#12422)

Fixes changes to the placeholder of a chip input not being propagated to its parent form field. Also un-deprecates the input for `placeholder`, because we need to know when it has changed.

Fixes #11861.
jelbourn pushed a commit that referenced this pull request Aug 7, 2018
@crisbeto @jelbourn
fix(chips): dynamic chip input placeholder changes not being propagat…
f1f1aa2 
…ed to form field (#12422)

Fixes changes to the placeholder of a chip input not being propagated to its parent form field. Also un-deprecates the input for `placeholder`, because we need to know when it has changed.

Fixes #11861.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chips placeholder bound to variable only shows after triggering its change detection (by clicking component).
3 participants
@crisbeto @jelbourn @googlebot