Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ripple): support multi-touch #12643

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Conversation

crisbeto
Copy link
Member

Currently when using multi-touch on a ripple trigger, the ripple will keep firing from the first touch position (e.g. putting one finger down and then tapping with another). These changes will fire off a ripple for each individual touch.

Currently when using multi-touch on a ripple trigger, the ripple will keep firing from the first touch position (e.g. putting one finger down and then tapping with another). These changes will fire off a ripple for each individual touch.
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Aug 12, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 12, 2018
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether this is the desired behavior. By looking at the Android ripples (which are primarily for touch), only the first ripple seems to be launched.

@crisbeto
Copy link
Member Author

I'm open towards changing it so no new ripples are fired until you've lifted your finger, but I thought that the point of the ripples was to get feedback whenever you've touched something.

@devversion
Copy link
Member

I agree with the ripples being more a feedback if someone touched something. That's what I also wrote to the ripples.md file. Since the subsequent touches are still interacting with the element, there should be some feedback.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 12, 2018
@jelbourn jelbourn merged commit 8fdc2cf into angular:master Aug 21, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants