fix(chips): focus not restored properly if chip has been removed by click #12788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
blocked
This comment has been minimized.
This comment has been minimized.
googlebot
added
the
cla: no
devversion
changed the title
devversion
force-pushed
the
fix/chips-focus-next-chip-click
branch
from
5c1a972 to
eef6a1e
Compare
This comment has been minimized.
This comment has been minimized.
devversion
force-pushed
the
fix/chips-focus-next-chip-click
branch
from
eef6a1e to
a9fcf08
Compare
|
CLAs look good, thanks! |
googlebot
added
cla: yes
devversion
added
action: merge
|
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
…lick * Currently if someone tries to remove a chip by clicking the `[matChipRemove]`, the click event will bubble up to the potential `MatFormField` and cause the `onContainerClick` to be invoked. This causes the focus to be always moved to the first chip (which is not good for accessibility). * Replaces multiple subscriptions in the chip list with a `takeUntil`. Also fixes that the chip remove subscription is re-created multiple times but not cleaned up. * Simplifies and cleans up the logic to restore focus after a chip has been destroyed. PR is based on: angular#12416
devversion
force-pushed
the
fix/chips-focus-next-chip-click
branch
from
a9fcf08 to
93c4b1f
Compare
|
@jelbourn Rebased. |
jelbourn
pushed a commit
that referenced
this pull request
Aug 29, 2018
…lick (#12788) * Currently if someone tries to remove a chip by clicking the `[matChipRemove]`, the click event will bubble up to the potential `MatFormField` and cause the `onContainerClick` to be invoked. This causes the focus to be always moved to the first chip (which is not good for accessibility). * Replaces multiple subscriptions in the chip list with a `takeUntil`. Also fixes that the chip remove subscription is re-created multiple times but not cleaned up. * Simplifies and cleans up the logic to restore focus after a chip has been destroyed. PR is based on: #12416
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if someone tries to remove a chip by clicking the
[matChipRemove], the click event will bubble up to the potentialMatFormFieldand cause theonContainerClickto be invoked. This causes the focus to be always moved to the first chip (which is not good for accessibility).Replaces multiple subscriptions in the chip list with a
takeUntil. Also fixes that the chip remove subscription is re-created multiple times but not cleaned up.Simplifies and cleans up the logic to restore focus after a chip has been destroyed.
Small demo that shows the issue in plain Angular: https://stackblitz.com/edit/chip-list-event-bubble-demo
NOTE: PR is based on: #12416