Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drag-drop): drop list not toggling dragging class inside component with OnPush change detection #13703

Merged
merged 1 commit into from
Nov 5, 2018
Merged

fix(drag-drop): drop list not toggling dragging class inside component with OnPush change detection #13703

merged 1 commit into from
Nov 5, 2018

Conversation

crisbeto
Copy link
Member

Fixes the CdkDropList not toggling its cdk-drop-list-dragging class if it's placed inside a component with OnPush change detection.

Fixes #13680.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 20, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 20, 2018
jelbourn
jelbourn approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 25, 2018
@jelbourn
Copy link
Member

jelbourn commented Nov 3, 2018

@crisbeto passes presubmit, just needs rebase

@ngbot
Copy link

ngbot bot commented Nov 3, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto
fix(drag-drop): drop list not toggling dragging class inside componen…
e5863b5 
…t with OnPush change detection

Fixes the `CdkDropList` not toggling its `cdk-drop-list-dragging` class if it's placed inside a component with `OnPush` change detection.

Fixes angular#13680.
@crisbeto crisbeto force-pushed the 13680/drop-list-dragging-on-push branch from 6f5ca4d to e5863b5 Compare November 4, 2018 17:30
@crisbeto
Copy link
Member Author

crisbeto commented Nov 4, 2018

Rebased.

@crisbeto crisbeto mentioned this pull request Nov 5, 2018
Closed
@jelbourn jelbourn merged commit 12c15ba into angular:master Nov 5, 2018
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
@crisbeto @jelbourn
fix(drag-drop): drop list not toggling dragging class inside componen…
4e50d4a 
…t with OnPush change detection (#13703)

Fixes the `CdkDropList` not toggling its `cdk-drop-list-dragging` class if it's placed inside a component with `OnPush` change detection.

Fixes #13680.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdk-drop-list: not add class .cdk-drop-list-dragging to CdkDropList container
3 participants
@crisbeto @jelbourn @googlebot