Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mat-menu's hasBackdrop attribute doesn't affect overaly when changes pro-grammatically #14560

Closed
lokeshdaiya opened this issue Dec 18, 2018 · 2 comments · Fixed by #14561
Closed

Mat-menu's hasBackdrop attribute doesn't affect overaly when changes pro-grammatically #14560

lokeshdaiya opened this issue Dec 18, 2018 · 2 comments · Fixed by #14561
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@lokeshdaiya
Copy link

What is the expected behavior?

We should be able to toggle overlay backdrop using input hasBackdrop

What is the current behavior?

If value is changed for hasBackdrop input programmatically then it does not apply the changes.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-gjsjab

  1. Open above link
  2. Inspect menu overlay for both true and false value.
  3. You will see class is not removed when we set it to false

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

7+

Is there anything else we should know?

image

image
@crisbeto crisbeto self-assigned this Dec 18, 2018
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Dec 18, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 18, 2018
@crisbeto
fix(menu): hasBackdrop not being updated after first open
a982288 
Fixes changing the `hasBackdrop` value not having an effect if it happens after the first time a menu is opened.

Fixes angular#14560.
@crisbeto crisbeto mentioned this issue Dec 18, 2018
Merged
@crisbeto
Copy link
Member

Note that in your example you forgot the square brackets around hasBackdrop which means that it's always set to true. That being said, the issue that you reported is still there and will be fixed by #14561.

jelbourn pushed a commit that referenced this issue Dec 19, 2018
@crisbeto @jelbourn
fix(menu): hasBackdrop not being updated after first open (#14561)
268b0e8 
Fixes changing the `hasBackdrop` value not having an effect if it happens after the first time a menu is opened.

Fixes #14560.
josephperrott pushed a commit to josephperrott/components that referenced this issue Jan 14, 2019
@crisbeto @josephperrott
fix(menu): hasBackdrop not being updated after first open (angular#14561
162ae3c 
)

Fixes changing the `hasBackdrop` value not having an effect if it happens after the first time a menu is opened.

Fixes angular#14560.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(menu): hasBackdrop not being updated after first open crisbeto/material2
2 participants
@crisbeto @lokeshdaiya