fix(menu): hasBackdrop not being updated after first open #14561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes changing the `hasBackdrop` value not having an effect if it happens after the first time a menu is opened. Fixes angular#14560.
googlebot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 18, 2018
Along the same lines as angular#14561. The connected overlay directive has an input on whether it should have a backdrop, however we only use it the first time we create the backdrop.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 18, 2018
Along the same lines as angular#14561. The connected overlay directive has an input on whether it should have a backdrop, however we only use it the first time we create the backdrop.
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Dec 19, 2018
Along the same lines as #14561. The connected overlay directive has an input on whether it should have a backdrop, however we only use it the first time we create the backdrop.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
) Fixes changing the `hasBackdrop` value not having an effect if it happens after the first time a menu is opened. Fixes angular#14560.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
Along the same lines as angular#14561. The connected overlay directive has an input on whether it should have a backdrop, however we only use it the first time we create the backdrop.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes changing the
hasBackdropvalue not having an effect if it happens after the first time a menu is opened.Fixes #14560.