fix(list): add hover and focus indication in high contrast mode #14637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
devversion
reviewed
Dec 25, 2018
| @@ -2,6 +2,7 @@ | |||
| @import '../core/style/list-common'; | |||
| @import '../core/style/layout-common'; | |||
| @import '../divider/divider-offset'; | |||
| @import '../../cdk/a11y/a11y'; | |||
There was a problem hiding this comment.
Can you please add the a11y dependency to the bazel build file?
It currently just depends on the a11y sass_library transitively being available in the Bazel deps
sass_binary(
name = "list_scss",
src = "list.scss",
deps = [
"//src/cdk/a11y:a11y_scss_lib", # <---
"//src/lib/core:core_scss_lib",
"//src/lib/divider:divider_scss_lib"
],
)I already walked through all build files and enforced this manually, but there is no real enforcement check yet.
devversion
approved these changes
Dec 25, 2018
Fixes not being able to see which lists/list items are focused or hovered in high contrast mode.
crisbeto
force-pushed
the
list-high-contrast-indication
branch
from
b4c56fa to
8cb8ed8
Compare
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…lar#14637) Fixes not being able to see which lists/list items are focused or hovered in high contrast mode.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes not being able to see which lists/list items are focused or hovered in high contrast mode.