feat(md-icon theming): added color attribute to md-icon for icon them… #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing, added test for md-icon theming, renamed _element to _elementRef to be more consistent with other components (#1888)
googlebot
added
the
cla: yes
|
@tdawgy you've got some lint errors: |
|
Sorry about that, should be resolved now. |
|
LGTM, thanks! It would also be helpful to file a follow-up PR to update the README |
jelbourn
added
pr: lgtm
action: merge
|
Why not include the README update in this PR? Just curious :) |
|
Typically should avoid changes after PR approval. |
|
Makes sense, thanks |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds theming to md-icon resolving issue #1888