fix(progress-spinner): Rename ProgressCircle to ProgressSpinner #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
changed the title
jelbourn
reviewed
Dec 20, 2016
| */ | ||
| @Component({ | ||
| moduleId: module.id, | ||
| selector: 'md-progress-circle, mat-progress-circle', | ||
| selector: 'md-progress-spinner, mat-progress-spinner', |
There was a problem hiding this comment.
We need to leave the old selectors as well so we can more easily migrate existing google projects
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| }) | ||
| export class MdProgressCircle implements OnDestroy { | ||
| export class MdProgressSpinner implements OnDestroy { |
There was a problem hiding this comment.
You can add at the bottom of this file
/** @deprecated */
export {MdProgressSpinner as MdProgressCircle};
/** @deprecated */
export {MdProgressSpinnerModule as MdProgressCircleModule};
// same for other symbolsthis will let people continue using the old symbols and let us migrate them incrementally.
tinayuangao
force-pushed
the
progress-spinner
branch
from
c2fe6cd to
326b829
Compare
|
Make selectors |
tinayuangao
force-pushed
the
progress-spinner
branch
from
ed1e42c to
f831e4a
Compare
|
Added progress-circle.ts. PTAL. Thanks! |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1495
R: @jelbourn