fix(compatibility): add missing mat- selectors #2923
Conversation
googlebot
added
the
cla: yes
src/lib/input/input-container.html
Outdated
| @@ -1,6 +1,8 @@ | |||
| <div class="md-input-wrapper"> | |||
| <div class="md-input-table"> | |||
| <div class="md-input-prefix"><ng-content select="[mdPrefix], [md-prefix]"></ng-content></div> | |||
| <div class="md-input-prefix"> | |||
| <ng-content select="[mdPrefix], [matPrefix], [md-prefix], [mat-prefix]"></ng-content> | |||
There was a problem hiding this comment.
don't add [mat-prefix], leave TODO to kill [md-prefix]
src/lib/input/input-container.html
Outdated
| @@ -19,7 +21,9 @@ | |||
| </label> | |||
| </div> | |||
|
|
|||
| <div class="md-input-suffix"><ng-content select="[mdSuffix], [md-suffix]"></ng-content></div> | |||
| <div class="md-input-suffix"> | |||
| <ng-content select="[mdSuffix], [matSuffix], [md-suffix], [mat-suffix]"></ng-content> | |||
There was a problem hiding this comment.
no [mat-suffix], TODO kill [md-suffix]
src/lib/menu/menu-trigger.ts
Outdated
| @@ -32,7 +32,8 @@ import {MenuPositionX, MenuPositionY} from './menu-positions'; | |||
| * responsible for toggling the display of the provided menu instance. | |||
| */ | |||
| @Directive({ | |||
| selector: '[md-menu-trigger-for], [mat-menu-trigger-for], [mdMenuTriggerFor]', | |||
| selector: `[md-menu-trigger-for], [mat-menu-trigger-for], | |||
|
tests seem unhappy for some reason |
src/lib/input/input-container.html
Outdated
| @@ -30,6 +36,6 @@ | |||
| [class.md-warn]="dividerColor == 'warn'"></span> | |||
| </div> | |||
|
|
|||
| <div *ngIf="hintLabel != ''" [attr.id]="_hintLabelId" class="md-hint">{{hintLabel}}</div> | |||
| <div *ngIf="hintLabel != ''" [attr.id]="_hintLabelId" class="md-hint, mat-hint">{{hintLabel}}</div> | |||
There was a problem hiding this comment.
Shouldn't md-hint be replaced with mat-hint rather than appended? Either way, comma should be removed.
There was a problem hiding this comment.
I think the comma might be what's breaking the tests
There was a problem hiding this comment.
Oh bugger I totally put that in the wrong spot, it should have been in the select attribute of the ng-content below it
andrewseguin
force-pushed
the
compat-consistency
branch
from
4cf2503 to
8675623
Compare
andrewseguin
force-pushed
the
compat-consistency
branch
from
8675623 to
9bf5041
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.