Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug(focus-trap): MS Edge: Shift-Tab goes out of the trap #3372

Closed
holo-michael-simarta opened this issue Mar 2, 2017 · 2 comments · Fixed by #9340
Closed

Bug(focus-trap): MS Edge: Shift-Tab goes out of the trap #3372

holo-michael-simarta opened this issue Mar 2, 2017 · 2 comments · Fixed by #9340
Assignees
@devversion
Labels
Accessibility This issue is related to accessibility (a11y) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@holo-michael-simarta
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Shift tab should go to the last element of the dialog

What is the current behavior?

Shift tab goes to

and does not reforcus, then continuing to shift tab would go the elements in the background of the dialog.

What are the steps to reproduce?

https://plnkr.co/edit/fGnZezVKDAcjOapZ5IyV?p=info

What is the use-case or motivation for changing an existing behavior?

A11Y

Which versions of Angular, Material, OS, browsers are affected?

Angular 2.4.5
Material 2.0.0-beta.2

Windows 10
Microsoft Edge 38.14393.0.0
Microsoft EdgeHTML 14.14393

Is there anything else we should know?

It is expecting a md-dialog-actions to find where the last item is but we want the actions to be beside the title. Current workaround right now is to specify the absolute position of the md-dialog-actions which is not ideal.
@jelbourn jelbourn added the Accessibility This issue is related to accessibility (a11y) label May 1, 2017
@jelbourn jelbourn self-assigned this May 1, 2017
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 1, 2017
@jelbourn jelbourn assigned devversion and unassigned jelbourn Jan 9, 2018
@devversion
Copy link
Member

This issue only seems to appear inside of <iframe> element, and Edge just prints Script5 Error: Access Denied.

I tracked it down to the isTabbable method that tries to access the frameElement, which is obviously critical to MS Edge.

devversion added a commit to devversion/material2 that referenced this issue Jan 11, 2018
@devversion
fix(interactivity-checker): carefully handle frame elements
e9068bc 
* Browsers like MS Edge throw errors if the frameElement property is being accessed from a different host address. This means that the `frameElement` property should be accessed carefully.

Fixes angular#3372
@devversion devversion mentioned this issue Jan 11, 2018
Merged
jelbourn pushed a commit that referenced this issue Jan 21, 2018
@devversion @jelbourn
fix(interactivity-checker): carefully handle frame elements
d4f7b10 
* Browsers like MS Edge throw errors if the frameElement property is being accessed from a different host address. This means that the `frameElement` property should be accessed carefully.

Fixes #3372
jelbourn pushed a commit that referenced this issue Jan 23, 2018
@devversion @jelbourn
fix(interactivity-checker): carefully handle frame elements (#9340)
6f7332b 
* Browsers like MS Edge throw errors if the frameElement property is being accessed from a different host address. This means that the `frameElement` property should be accessed carefully.

Fixes #3372
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 29, 2018
@devversion @jelbourn
fix(interactivity-checker): carefully handle frame elements (angular#…
305a81c 
…9340)

* Browsers like MS Edge throw errors if the frameElement property is being accessed from a different host address. This means that the `frameElement` property should be accessed carefully.

Fixes angular#3372
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
Accessibility This issue is related to accessibility (a11y) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(interactivity-checker): carefully handle frame elements devversion/material2
3 participants
@jelbourn @devversion @holo-michael-simarta