Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): allow pointer events on placeholder #3878

Merged
merged 1 commit into from
Apr 17, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 2, 2017

Removes the pointer-events: none from the input placeholder in order to allow for users to bind events to it. Clicking through isn't necessary anyway, because it automatically redirects focus to the underlying input already.

Removes the `pointer-events: none` from the input placeholder in order to allow for users to bind events to it. Clicking through isn't necessary anyway, because it automatically redirects focus to the underlying input already.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 2, 2017
@mmalerba
Copy link
Contributor

mmalerba commented Apr 3, 2017

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 5, 2017
@aldo-roman
Copy link

Fixes #3823

@jelbourn jelbourn added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Apr 11, 2017
@jelbourn
Copy link
Member

This somehow made one project's e2e tests start to fail, needs investigation by caretaker.

@aldo-roman
Copy link

Hi @jelbourn do you have any link where to inspect the failed tests? The bot just mentioned all Travis build passed, including e2e

https://travis-ci.org/angular/material2/jobs/217799152

@jelbourn
Copy link
Member

jelbourn commented Apr 13, 2017

@aldo-roman before merging on PRs we run them against the tests for all Google applications that use the components. This happens on Google's internal infrastructure rather than on github / travis.

The team that owns these particular tests have made a change that should resolve the issue, I'll be able to confirm when the next set of commits are synced.

@jelbourn jelbourn removed the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Apr 14, 2017
@jelbourn jelbourn merged commit 32b7426 into angular:master Apr 17, 2017
mmalerba added a commit to mmalerba/components that referenced this pull request Apr 21, 2017
mmalerba added a commit to mmalerba/components that referenced this pull request Apr 21, 2017
mmalerba added a commit to mmalerba/components that referenced this pull request Apr 21, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants