-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input): allow pointer events on placeholder #3878
fix(input): allow pointer events on placeholder #3878
Conversation
Removes the `pointer-events: none` from the input placeholder in order to allow for users to bind events to it. Clicking through isn't necessary anyway, because it automatically redirects focus to the underlying input already.
LGTM |
Fixes #3823 |
This somehow made one project's e2e tests start to fail, needs investigation by caretaker. |
Hi @jelbourn do you have any link where to inspect the failed tests? The bot just mentioned all Travis build passed, including e2e |
@aldo-roman before merging on PRs we run them against the tests for all Google applications that use the components. This happens on Google's internal infrastructure rather than on github / travis. The team that owns these particular tests have made a change that should resolve the issue, I'll be able to confirm when the next set of commits are synced. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removes the
pointer-events: none
from the input placeholder in order to allow for users to bind events to it. Clicking through isn't necessary anyway, because it automatically redirects focus to the underlying input already.