fix(autocomplete): handle escape key #4703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
kara
approved these changes
May 22, 2017
kara
added
pr: lgtm
action: merge
jelbourn
reviewed
May 22, 2017
| @@ -231,7 +231,9 @@ export class MdAutocompleteTrigger implements ControlValueAccessor, OnDestroy { | |||
| } | |||
|
|
|||
| _handleKeydown(event: KeyboardEvent): void { | |||
| if (this.activeOption && event.keyCode === ENTER) { | |||
| if (event.keyCode === ESCAPE) { | |||
| this.panelOpen ? this.closePanel() : this._element.nativeElement.blur(); | |||
There was a problem hiding this comment.
Where does this blur put the focus? If it dumps it back to the body, then we don't want this behavior
There was a problem hiding this comment.
I tested that manually, and it seems to go to the next in the tab order on TAB. But the active element is the body. Thoughts?
There was a problem hiding this comment.
@crisbeto Discussed a bit, and seems like a noop might be a better choice if the panel is closed given screenreader support.
crisbeto
force-pushed
the
autocomplete-escape
branch
from
a84b4e0 to
4681e43
Compare
|
Removed the |
kara
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
autocomplete-escape
branch
from
4681e43 to
e100f6e
Compare
* Closes the autocomplete panel when pressing escape. * Switches the autocomplete unit tests to using the common utility for creating fake keyboard events.
crisbeto
force-pushed
the
autocomplete-escape
branch
from
e100f6e to
e08ca2d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(autocomplete): handle escape key