feat(snack-bar): allow setting the layout direction #4726
Merged
+54
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows the consumer to set the layout direction of a snack bar. * Fixes some bad indentation in the snack bar tests. Fixes angular#4721.
googlebot
added
the
cla: yes
jelbourn
reviewed
May 22, 2017
| @@ -28,4 +28,9 @@ $mat-snack-bar-button-margin: 48px !default; | |||
| size: inherit; | |||
| weight: 600; | |||
| } | |||
|
|
|||
| /deep/ [dir='rtl'] & { | |||
There was a problem hiding this comment.
I would like to avoid having /deep/ anywhere in the library.
(and prefer turning off ViewEncapsulation)
There was a problem hiding this comment.
Done. Also fixed the button not being uppercase for some reason.
|
I re-added it, because it seemed off based on the spec and I remembered it being there at some point. I'll remove it when I get back home. |
jelbourn
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 27, 2017
Adds a custom Stylelint rule to prevent usages of `/deep/` inside selectors. Relates angular#4726.
mmalerba
pushed a commit
that referenced
this pull request
May 31, 2017
* build: add stylelint rule to prevent usage of /deep/ Adds a custom Stylelint rule to prevent usages of `/deep/` inside selectors. Relates #4726. * fix: address feedback
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4721.