-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabs): add theming and ability to set background color #5287
Conversation
1065201
to
9abc786
Compare
I definitely need to rework this to cut down on how much css is generated |
How about something like: $theme-colors: (
primary: $primary,
accent: $accent,
warn: $warn
);
@each $name, $color in $theme-colors {
&.mat-#{$name} {
@include _mat-tab-label-focus($color);
@include _mat-ink-bar($color);
}
&.mat-background-#{$name} {
@include _mat-tab-label-focus($color);
@include _mat-tabs-background($color);
}
&.mat-#{$name}.mat-background-#{$name} {
@include _mat-ink-bar($color, default-contrast);
}
} |
80b5d88
to
ff787d7
Compare
Review on this one might be delayed a bit (Andrew is wrapping up initial data table stuff) |
@jelbourn fair, thank you for the update |
ff787d7
to
3cc92d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the thorough work and your patience for the review. One suggestion, can you rename the background
input to backgroundColor
? Also, you'll need to rebase
3cc92d1
to
afe165a
Compare
@andrewseguin done, PTAL |
@willshowell Can you rebase again? Sorry! |
afe165a
to
1efac4b
Compare
@kara done! |
- Rework sass for smaller output - make mixin base classes docs private (angular#5301) - Use each directive for less repetition - Rename background to backgroundColor
1efac4b
to
2729c43
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #1362
Fixes #2908
Fixes #5014