Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkbox: change event emits [Event] instead of boolean #544

Closed
devversion opened this issue May 27, 2016 · 2 comments · Fixed by #551
Closed

checkbox: change event emits [Event] instead of boolean #544

devversion opened this issue May 27, 2016 · 2 comments · Fixed by #551
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone
alpha.6

Comments

@devversion
Copy link
Member

devversion commented May 27, 2016 •
edited
Loading

Sometimes, when triggering the change event on the input, by clicking on it, the change output will emit the actual event object, instead of the correct boolean.

Already working on a PR, which includes some tests and fixes it.

Sample test (without fix)
image

After searching in the Angular Repository I found the right issue
@jelbourn
Copy link
Member

@devversion we actually want the checkbox to fire something like an MdCheckboxChange event if you wanted to PR that instead.

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 27, 2016
@jelbourn jelbourn added this to the alpha.6 milestone May 27, 2016
devversion added a commit to devversion/material2 that referenced this issue May 27, 2016
@devversion
fix(): visual hidden inputs should not bubble change event
c40893b 
* Currently the change event of the visual hidden inputs will bubble up and emit its event object to the component's `change` output.

This is currently an issue of Angular 2
- See angular/angular#4059

To prevent the events from bubbling up, we have to stop propagation on
change.

Fixes angular#544.
@devversion devversion mentioned this issue May 27, 2016
Merged
devversion added a commit to devversion/material2 that referenced this issue May 27, 2016
@devversion
fix(): visual hidden inputs should not bubble change event
5bd4881 
* Currently the change event of the visual hidden inputs will bubble up and emit its event object to the component's `change` output.

This is currently an issue of Angular 2
- See angular/angular#4059

To prevent the events from bubbling up, we have to stop propagation on
change.

Fixes angular#544.
devversion added a commit to devversion/material2 that referenced this issue May 27, 2016
@devversion
fix(): visual hidden inputs should not bubble change event
aba553c 
* Currently the change event of the visual hidden inputs will bubble up and emit its event object to the component's `change` output.

This is currently an issue of Angular 2
- See angular/angular#4059

To prevent the events from bubbling up, we have to stop propagation on
change.

Fixes angular#544.
jelbourn pushed a commit that referenced this issue May 27, 2016
@devversion @jelbourn
fix: visually hidden inputs should not bubble change event (#551)
d037ed3 
* fix(): visual hidden inputs should not bubble change event

* Currently the change event of the visual hidden inputs will bubble up and emit its event object to the component's `change` output.

This is currently an issue of Angular 2
- See angular/angular#4059

To prevent the events from bubbling up, we have to stop propagation on
change.

Fixes #544.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
alpha.6
Development

Successfully merging a pull request may close this issue.

fix(): visual hidden inputs should not bubble change event devversion/material2
2 participants
@jelbourn @devversion