fix(stepper): unable to internationalize labels #7122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Sep 16, 2017
src/lib/stepper/stepper.md
Outdated
| @@ -124,11 +124,26 @@ this default `completed` behavior by setting the `completed` attribute as needed | |||
| - <kbd>TAB</kbd>: Focuses the next tabbable element | |||
| - <kbd>TAB</kbd>+<kbd>SHIFT</kbd>: Focuses the previous tabbable element | |||
|
|
|||
| ### Localizing labels | |||
| The various text strings used by the stepper are provided through `MdStepperIntl`. | |||
There was a problem hiding this comment.
The various text strings -> Labels
crisbeto
force-pushed
the
stepper-intl
branch
from
3675b9f to
e890643
Compare
crisbeto
force-pushed
the
stepper-intl
branch
from
e890643 to
5280e4a
Compare
crisbeto
force-pushed
the
stepper-intl
branch
2 times, most recently
from
4728389 to
5c88226
Compare
|
@crisbeto Can you check out the linter failure? Looks like there could be an unused import in step-header. |
Adds a provider that allows for labels inside the stepper to be internationalized.
|
Rebased and sorted out the linting issue. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a provider that allows for labels inside the stepper to be internationalized.