Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidenav fails to emit FIRST onClose event #7208

Closed
jayoma opened this issue Sep 20, 2017 · 1 comment · Fixed by #7214
Closed

Sidenav fails to emit FIRST onClose event #7208

jayoma opened this issue Sep 20, 2017 · 1 comment · Fixed by #7214
Assignees

Comments

@jayoma
Copy link

jayoma commented Sep 20, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

When page loads with sidenav in the opened state, the onClose output event should be emitted the very first (and every subsequent) time the sidenav is closed.

What is the current behavior?

The onClose output event is not emitted the FIRST time the sidenav is closed, but is emitted every time thereafter.

What are the steps to reproduce?

Plunker template: https://plnkr.co/edit/pAcVegKBaqKCsoRRQyko?p=preview

!! make sure to open developer tools to see the console logging I've added, before toggling sidenav !!

What is the use-case or motivation for changing an existing behavior?

The event should fire reliably, whether it's the first or nth time the sidenav is toggled.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular: 4.4.1, Material: 2.0.0-beta.10, Chrome and IE at least

Is there anything else we should know?

@crisbeto crisbeto self-assigned this Sep 20, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 20, 2017
Fixes a regression that caused the drawer not to fire its `open` event if it is open on init.

Fixes angular#7208.
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 29, 2017
Fixes a regression that caused the drawer not to fire its `open` event if it is open on init.

Fixes angular#7208.
andrewseguin pushed a commit that referenced this issue Sep 29, 2017
Fixes a regression that caused the drawer not to fire its `open` event if it is open on init.

Fixes #7208.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants